Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @interledger/http-signature-utils to v2.0.2 #2434

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@interledger/http-signature-utils (source) 2.0.1 -> 2.0.2 age adoption passing confidence

Release Notes

interledger/open-payments (@​interledger/http-signature-utils)

v2.0.2

Compare Source

Patch Changes
  • 2658685: Upgrade the http-message-signatures package to the most recent version.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency label Feb 21, 2024
@github-actions github-actions bot added pkg: backend Changes in the backend package. pkg: auth Changes in the GNAP auth package. pkg: mock-ase labels Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 78cd73f
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/65e98fb2e7116c00089f2f7e

@renovate renovate bot force-pushed the renovate-interledger-http-signature-utils-2.x branch 2 times, most recently from f0741f3 to 8fb1ced Compare February 26, 2024 10:22
@renovate renovate bot force-pushed the renovate-interledger-http-signature-utils-2.x branch from 8fb1ced to 22dd2bb Compare March 4, 2024 09:19
@renovate renovate bot force-pushed the renovate-interledger-http-signature-utils-2.x branch from 22dd2bb to ab0f6ff Compare March 5, 2024 09:18
@github-actions github-actions bot added the type: source Changes business logic label Mar 7, 2024
@@ -42,7 +42,7 @@ function contextToRequestLike(ctx: HttpSigContext): RequestLike {
return {
url,
method: ctx.method,
headers: ctx.headers,
headers: JSON.parse(JSON.stringify(ctx.headers)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a chance at all that ctx.headers is undefined? if so, we'll get an error.

I think we should either just do as Record<string, string | string[]> or write a type guard to check for undefined or null values in the ctx.headers object

Copy link
Contributor Author

renovate bot commented Mar 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer just the as ... method (since JSON.parse is basically typing it as any and we wouldn't need to change the runtime code), but doesn't make too much of a difference

@sabineschaller sabineschaller merged commit e5d1d0f into main Mar 7, 2024
22 checks passed
@sabineschaller sabineschaller deleted the renovate-interledger-http-signature-utils-2.x branch March 7, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: mock-ase type: source Changes business logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants