-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @interledger/http-signature-utils to v2.0.2 #2434
fix(deps): update dependency @interledger/http-signature-utils to v2.0.2 #2434
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
f0741f3
to
8fb1ced
Compare
8fb1ced
to
22dd2bb
Compare
22dd2bb
to
ab0f6ff
Compare
@@ -42,7 +42,7 @@ function contextToRequestLike(ctx: HttpSigContext): RequestLike { | |||
return { | |||
url, | |||
method: ctx.method, | |||
headers: ctx.headers, | |||
headers: JSON.parse(JSON.stringify(ctx.headers)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a chance at all that ctx.headers
is undefined? if so, we'll get an error.
I think we should either just do as Record<string, string | string[]>
or write a type guard to check for undefined
or null
values in the ctx.headers
object
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer just the as ...
method (since JSON.parse is basically typing it as any
and we wouldn't need to change the runtime code), but doesn't make too much of a difference
This PR contains the following updates:
2.0.1
->2.0.2
Release Notes
interledger/open-payments (@interledger/http-signature-utils)
v2.0.2
Compare Source
Patch Changes
2658685
: Upgrade thehttp-message-signatures
package to the most recent version.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.